Jeremy lig 4470 proxy #1494
Merged
Jeremy lig 4470 proxy #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will test and give feedback as soon as this has landed in the worker. @japrescott Please ping me if this is the case. Thank you. |
MalteEbner
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes lig-4470
closes #1492
Changes
ALL_PROXY,HTTPS_PROXYorHTTP_PROXYenvironment vars are set, pass that information to swagger which triggers the usageurllib3.ProxyManager. According to Olivier Benz this should resolve the issue of using lightly behind a corporate mitm proxy.Tests