Skip to content

Commit

Permalink
bol09: Specify behavior when a node specifies both optional and requi…
Browse files Browse the repository at this point in the history
…red features

While reviewing a patch on lnprototest, I encountered a scenario
where the BOLT 9 specification needed to provide clear guidance.

As a result, this commit adds specific requirements to
determine the appropriate behaviour when a node specifies
both optional and required features.

Additionally, if this situation appears to be an
implementation bug, it will be taken care of accordingly.

Reported-by: lnprototest
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
  • Loading branch information
vincenzopalazzo committed Jul 15, 2023
1 parent e0995c9 commit 2e54fc9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions 09-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ The origin node:
* If it requires a feature above, MUST set the corresponding even
feature bit in all feature fields indicated by the Context column,
unless indicated that it must set the odd feature bit instead.
* If a feature is specified both as an optional feature and as a
required feature in the header, the more restrictive option MUST be chosen.
* MUST NOT set feature bits it does not support.
* MUST NOT set feature bits in fields not specified by the table above.
* MUST set all transitive feature dependencies.
Expand Down

0 comments on commit 2e54fc9

Please sign in to comment.