Bolt4: clarify packet forwarding blinding #1012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently says the blinding is done using the processing node's public key which is not correct. Instead of trying to explain how blinding works again, just link to the section that describes it.
johncantrell97
changed the title
t-bast
reviewed
Aug 12, 2022
| @@ -679,8 +679,7 @@ A special `hmac` value of 32 `0x00`-bytes indicates that the currently processin | |||
|
|
|||
| If the HMAC does not indicate route termination, and if the next hop is a peer of the | |||
| processing node; then the new packet is assembled. Packet assembly is accomplished | |||
| by blinding the ephemeral key with the processing node's public key, along with the | |||
| shared secret, and by serializing the `hop_payloads`. | |||
| by (blinding the ephemeral key)[#blinding-ephemeral-keys], and by serializing the `hop_payloads`. | |||
There was a problem hiding this comment.
This doesn't correctly display the link, this should work:
Suggested change
| by (blinding the ephemeral key)[#blinding-ephemeral-keys], and by serializing the `hop_payloads`. | |
| by [blinding the ephemeral key](#blinding-ephemeral-keys), and by serializing the `hop_payloads`. |
25 tasks
25 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently says the blinding is done using the processing node's public key which is not correct. Instead of trying to explain how blinding works again, just link to the section that describes it.