-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a mechanism for looking up an offer from a user/domain pair #1136
Closed
TheBlueMatt
wants to merge
13
commits into
lightning:master
from
TheBlueMatt:2024-02-offers-request-om
+1,589
−5
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f0e4fc7
BOLT 1: add bip340sig type.
rustyrussell 21cc0ba
BOLT 1: Add utf8 type.
rustyrussell 5bd55f2
tools/spellcheck.sh: more generally ignore things inside ``.
rustyrussell fdc8f23
BOLT 12: offers, sixth draft
rustyrussell 92deb12
BOLT 4: add bolt12 payloads to onion message payloads.
rustyrussell e2c3a85
fixup! BOLT 12: offers, sixth draft
rustyrussell 0be484d
fixup! BOLT 12: offers, sixth draft
rustyrussell fe6c2c6
bolt12: add test vectors for offers.
rustyrussell ba2b95a
Allow using `short_channel_id` in onion messages
jkczyz 3db064e
Add a `sciddir_or_pubkey` fundamental type
jkczyz 9118a8f
fixup! bolt12: add test vectors for offers.
rustyrussell a3f3815
Define a URI encoding for BOLT12 offers
TheBlueMatt 5809dfd
Define a mechanism for looking up an offer from a user/domain pair
TheBlueMatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
* [Invoice Requests](#invoice-requests) | ||
* [Invoices](#invoices) | ||
* [Invoice Errors](#invoice-errors) | ||
* [Offer Requests](#offer-requests) | ||
|
||
# Limitations of BOLT 11 | ||
|
||
|
@@ -824,6 +825,26 @@ sender of the invoice would have to guess how many msat that was, | |
and could use the `invoice_error` to indicate if the recipient disagreed | ||
with the conversion so the sender can send a new invoice. | ||
|
||
# Offer Requests | ||
|
||
`bitcoin:` URIs with a query paraketer key (case-insensitive) of `omlookup` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
indicate that an offer should be requested over onion messages. The value in | ||
the query parameter should be a hex-encoded `blinded_path` which represents a | ||
(FIXME: Use a specific name here for blinded paths for onion messages) | ||
recipient to send an `offer_request`-containing onion message to. These URIs | ||
only make sense in the context of a BIP XXXX resolution, where a sender is | ||
resolving a `name`/`domain` pair to payment instructions. | ||
|
||
## Requirements | ||
The sender of an `offer_request`-containing onion message: | ||
* MUST set `name` and `domain` to printable ASCII charachters only, | ||
* MUST set `domain` to a canonically-encoded domain name, ending in a "." | ||
|
||
The recipient of an `offer_request`-containing onion message: | ||
* if the `name` and `domain` describe a recipient it is responsible for, SHOULD | ||
reply with an `offer_response`-containing onion message with the same `name` | ||
and `domain`. | ||
|
||
# FIXME: Possible future extensions: | ||
|
||
1. The offer can require delivery info in the `invoice_request`. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: