Drop the required channel_update in failure onions
#1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
approved these changes
Jun 17, 2024
22 tasks
Roasbeef
reviewed
Jun 17, 2024
23 tasks
Roasbeef
approved these changes
Jul 1, 2024
As noted previously, `channel_update`s in the onion failure packets are massive gaping fingerprintign vulnerabilities - if a node applies them in a publicly-visible way the err'ing node can easily identify the sender of an HTLC. While the updates are still arguably marginally useful for nodes to use in their pathfinding local to retires of the same payment, this too will eventually become an issue with PTLCs. Further, we shouldn't be letting nodes get away with delaying payments by failing to announce the latest channel parameters or enforcing new parameters too soon, so treating the node as having indicated insufficient liquidity (or other general failure) is appropriate in the general case. Thus, here, we begin phasing out the `channel_update` field, requiring nodes ignore it outside of the current payment and making it formally optional (though nodes have been doing this for some time due to various bugs). Because some nodes may want to use update data on mobile when they have stale gossip data, it is left optional.
TheBlueMatt
force-pushed
the
2024-06-dont-look-at-updates-in-onions
branch
from
3344779 to
9497394
Compare
|
Fixed the typo. |
t-bast
approved these changes
Jul 11, 2024
tankyleo
added a commit
to tankyleo/rust-lightning
that referenced
this pull request
Oct 1, 2024
tankyleo
added a commit
to tankyleo/rust-lightning
that referenced
this pull request
Oct 4, 2024
tankyleo
added a commit
to tankyleo/rust-lightning
that referenced
this pull request
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted previously,
channel_updates in the onion failure packets are massive gaping fingerprintign vulnerabilities - if a node applies them in a publicly-visible way the err'ing node can easily identify the sender of an HTLC.While the updates are still arguably marginally useful for nodes to use in their pathfinding local to retires of the same payment, this too will eventually become an issue with PTLCs. Further, we shouldn't be letting nodes get away with delaying payments by failing to announce the latest channel parameters or enforcing new parameters too soon, so treating the node as having indicated insufficient liquidity (or other general failure) is appropriate in the general case.
Thus, here, we begin phasing out the
channel_updatefield, requiring nodes ignore it outside of the current payment and making it formally optional (though nodes have been doing this for some time due to various bugs).Because some nodes may want to use update data on mobile when they have stale gossip data, it is left optional.
An alternative to #1163 for those that want to use the updates.