BOLT 12: first draft of payer proofs #1295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
25 tasks
jkczyz
reviewed
Nov 11, 2025
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Some minor comments from a first pass. Should have more feedback once we attempt to implement this.
| * [`bip340sig`:`sig`] | ||
| 1. type: 242 (`preimage`) | ||
| 2. data: | ||
| * [`32*byte`:`premage`] |
|
|
||
| The non-signature elements of a payer proof are identical to the | ||
| `invoice` tlv_stream, with the exception that `invreq_metadata` cannot | ||
| be included. Various fields are omitted for privacy: numbers |
|
|
||
| A writer of a payer_proof: | ||
| - MUST NOT include `invreq_metadata`. | ||
| - MUST include `invreq_payer_id`, `invoice_payment_hash`, `invoice_node_id`, `signature` and (if present) `invoice_features` from the invoice. |
Contributor
There was a problem hiding this comment.
Could you include a rationale for requiring invoice_features?
| - `omitted_tlvs` contains 0. | ||
| - `omitted_tlvs` contains signature TLV element number (240 through 1000 inclusive). | ||
| - `omitted_tlvs` contains the number of an included TLV field. | ||
| - `omitted_tlvs` contains more than one number larger than the largest included non-signature TLV element. |
Contributor
There was a problem hiding this comment.
Not sure I understand this restriction. Why can't more than one such TLV be omitted? The example contradicts this (41 and 42), IIUC.
Collaborator
Author
There was a problem hiding this comment.
Oops, this was from an earlier draft, and should be removed!
|
|
||
| Note that the signature TLV 250 is not included in the merkle tree. | ||
|
|
||
| `leaf_hashes` contains the nonce hashes for the present non-signature TLVS: |
| 1. type: 250 (`payer_signature`) | ||
| 2. data: | ||
| * [`bip340sig`:`sig`] | ||
| * [`...*utf8`:`note`] |
Contributor
There was a problem hiding this comment.
Presumably, this may be empty?
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: