Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchors: follow up changes after initial zero fee anchors merge #903

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

Roasbeef
Copy link
Collaborator

Fixup changes:

  • features: make anchor zero fee explicitly dependent on static key
  • re-order section explaining new HTLC output trimming

@t-bast
Copy link
Collaborator

t-bast commented Aug 31, 2021

re-order section explaining new HTLC output trimming

I don't see this one?

Could you also fix the tiny typo referenced here: https://github.com/lightningnetwork/lightning-rfc/pull/824/files#r698775217 ?

@rustyrussell
Copy link
Collaborator

We can fix this too, I just noticed:

BOLT #2:

 A receiving node:
  - if `option_static_remotekey` or `option_anchors` applies to the commitment transaction:
    - if `next_revocation_number` is greater than expected above, AND

The "or option_anchors" is now redundant...

@rustyrussell
Copy link
Collaborator

This too...:

	 * The sending node:
	 *   - MUST set `next_commitment_number` to the commitment number
	 *     of the next `commitment_signed` it expects to receive.
	 *   - MUST set `next_revocation_number` to the commitment number
	 *     of the next `revoke_and_ack` message it expects to receive.
	 *   - if `option_static_remotekey` or `option_anchors` applies to the commitment transaction:

@ariard
Copy link

ariard commented Sep 5, 2021

See my comment here : https://github.com/lightningnetwork/lightning-rfc/pull/824/files#r698781292. At least might be good to precise combination should only be done with transactions within the same "safety" domain (equal or 0-value nLocktime, non-third-party spendable scripts, SIGHASH_ALL lockdown of inputs, ?). Otherwise it's left to implementer wisdom which have proven tricky to get right in this area.

@t-bast
Copy link
Collaborator

t-bast commented Oct 21, 2021

@Roasbeef any progress on this PR? I can take it over if you don't have time, let me know.

@Roasbeef
Copy link
Collaborator Author

Roasbeef commented Dec 6, 2021

Pushed up extra commits addressing Rusty's comment.

re-order section explaining new HTLC output trimming

TBH, it's been so long with this PR that I forgot what I was going to do here...

02-peer-protocol.md Outdated Show resolved Hide resolved
So we can remove references to anchors here, as you need static key in
order to support it, so that reference is redundant.
@Roasbeef Roasbeef force-pushed the anchors-zero-fee-fixups branch from 159de44 to 779f366 Compare January 3, 2022 19:30
@Roasbeef Roasbeef requested a review from t-bast January 3, 2022 19:30
Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 779f366

@t-bast t-bast merged commit ea37941 into lightning:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants