Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the sighash types for HTLC Success and Timeout transactions #954

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Clarify the sighash types for HTLC Success and Timeout transactions #954

merged 1 commit into from
Jan 31, 2022

Conversation

ksedgwic
Copy link
Contributor

No description provided.

@t-bast
Copy link
Collaborator

t-bast commented Jan 17, 2022

This is already stated here: https://github.com/lightning/bolts/blob/master/05-onchain.md#generation-of-htlc-transactions
Maybe you can instead just add a link to it?

@ksedgwic ksedgwic force-pushed the clarify-htlc-anchor-sighash branch from 0b0aa55 to 655915c Compare January 19, 2022 19:19
@ksedgwic
Copy link
Contributor Author

This is already stated here: https://github.com/lightning/bolts/blob/master/05-onchain.md#generation-of-htlc-transactions Maybe you can instead just add a link to it?

Sounds good, how does this look?

t-bast
t-bast approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ACK 655915c

vincenzopalazzo
vincenzopalazzo approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 655915c

@t-bast t-bast mentioned this pull request Jan 27, 2022
Closed
17 tasks
@rustyrussell
Copy link
Collaborator

Ack 655915c

@t-bast t-bast merged commit d975de1 into lightning:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ksedgwic @t-bast @rustyrussell @TheBlueMatt @vincenzopalazzo