BOLT 1: make remote_addr definition machine readable. #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
the
spelling
It will name the structure just If thats okay, I can ack |
t-bast
reviewed
May 17, 2022
|
Seems like I still can't push into Rusty's branch. We need to wait for him... |
It had a blank line and invalid format for tools/extract-formats.py. And move the format information into the requirements section (and fix spelling: `node_announement` -> `node_announcement` Diff for extract-formats.py before and after: ```diff --- /tmp/before 2022-05-17 10:47:01.583086352 +0930 +++ /tmp/after 2022-05-17 10:51:59.166850111 +0930 @@ -6,6 +6,8 @@ msgdata,init,tlvs,init_tlvs, tlvtype,init_tlvs,networks,1 tlvdata,init_tlvs,networks,chains,chain_hash,... +tlvtype,init_tlvs,remote_addr,3 +tlvdata,init_tlvs,remote_addr,data,byte,... msgtype,error,17 msgdata,error,channel_id,channel_id, msgdata,error,len,u16, ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
bolt1-blank-line
branch
from
248ab54
to
f1c797d
Compare
Fixed, description, thanks! (I changed it at the last moment, after I generated that diff!) |
t-bast
approved these changes
May 17, 2022
TheBlueMatt
approved these changes
May 17, 2022
|
OK, applying under the "spelling and typos" rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had a blank line and invalid format for tools/extract-formats.py. This meant that the python package omitted it!
And move the format information into the requirements section
(and fix spelling:
node_announement->node_announcementDiff for extract-formats.py before and after:
Signed-off-by: Rusty Russell rusty@rustcorp.com.au