CI: we decide the pyln-testing version to be installed #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes a few tests currently failing for 24.11 |
chrisguida
force-pushed
the
ci-pyln-install
branch
from
6d1a221 to
7f7373e
Compare
|
Cool, thanks for catching that! |
chrisguida
force-pushed
the
ci-pyln-install
branch
2 times, most recently
from
ad84a8c to
942c62c
Compare
chrisguida
force-pushed
the
ci-pyln-install
branch
from
942c62c to
7101739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't let plugins dictate which version of pyln-testing will be installed for testing. Due to missing backward/forward compatibility and no way for plugin repos to tell which CLN versions they are being tested on we must set the correct pyln-testing version. For this i added/moved this to the last step of setting up the pyton environments.