Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override fee rate for on-chain operations #176

Open
tnull opened this issue Oct 25, 2023 · 2 comments
Open

Allow to override fee rate for on-chain operations #176

tnull opened this issue Oct 25, 2023 · 2 comments
Milestone

Comments

@tnull
Copy link
Collaborator

tnull commented Oct 25, 2023

We should allow to override our fee estimation for methods like Node::send_to_onchain_address.

It would however make sense to expose this as an Option<bitcoin::FeeRate> in the API. To avoid immediately breaking API again, we should therefore wait until we could upgrade to rust-bitcoin 0.30 which introduced FeeRate.

@jbesraa
Copy link
Contributor

jbesraa commented Feb 12, 2024

hey, I would like to work on this please.

It seems like bdk is using its own FeeRate in the tx builder, if we are using bitcoin::FeeRate I guess we should convert from bitcoin::FeeRate to bdk::FeeRate as well?

@tnull
Copy link
Collaborator Author

tnull commented Feb 12, 2024

It seems like bdk is using its own FeeRate in the tx builder, if we are using bitcoin::FeeRate I guess we should convert from bitcoin::FeeRate to bdk::FeeRate as well?

Mhh, they are planning to drop their implementation for bitcoin::FeeRate for quite a while now and seem like they are close to finally pulling the trigger (see bitcoindevkit/bdk#1136 / bitcoindevkit/bdk#1216). I'd really avoid to introduce too many unnecessary conversions and churn in exposed types, which is why I deferred doing this until the BDK 1.0 upgrade.

I still tend towards this, but if you're eager to pick it up right now we could indeed consider exposing bitcoin::FeeRate in the API, converting from/to bdk::FeeRate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants