Skip to content

Track inbound payments by also unique payment IDs #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks
tnull opened this issue May 22, 2024 · 0 comments
Open
3 tasks

Track inbound payments by also unique payment IDs #298

tnull opened this issue May 22, 2024 · 0 comments
Milestone
0.6

Comments

@tnull
Copy link
Collaborator

tnull commented May 22, 2024 •
edited
Loading

After #256, we won't track inbound BOLT12 payments until PaymentClaimable, which differs from the prior BOLT11 behavior. Eventually we should:

  • Add an invoice/offer store (see Make invoice storage optional #51) and register created invoices in this rather than the payment store. The invoice/offer store entries should have a link to the associated PaymentId(s)
  • Add a PaymentId field to PaymentClaimable/PaymentReceived, e.g., derived from the HTLC Id + inbound channel
  • Then migrate to track all payments (inbound or outbound) only by the LDK-provided PaymentIds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@tnull