Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding last_updated field to PaymentDetails #57

Closed
tnull opened this issue Apr 3, 2023 · 2 comments · Fixed by #308
Closed

Consider adding last_updated field to PaymentDetails #57

tnull opened this issue Apr 3, 2023 · 2 comments · Fixed by #308

Comments

@tnull
Copy link
Collaborator

tnull commented Apr 3, 2023

This would allow the user to query for 'recent' payments based on a suitable filter.

In order to do this nicely we should however consider implementing Writeable/Readable for SystemTime upstream.

@tnull tnull mentioned this issue Feb 21, 2024
19 tasks
@jbesraa
Copy link
Contributor

jbesraa commented Mar 5, 2024

Can you please say more about the Writeable/Readable for SystemTime ?

If we add last_updated to PaymentDetails and PaymentDetailsUpdate, while in the later its set to last_updated: SystemTime::now() .duration_since(UNIX_EPOCH) .expect("Time went backwards") .as_secs(),
wouldnt that work?

iam actually assuming you are referring to unix time but not sure thats correct?

@tnull
Copy link
Collaborator Author

tnull commented Mar 5, 2024

Yes, we could consider adding just the UNIX timestamp, but might also want to add the Writeable/Readable impl to rust-lightning, we'll see. I will pick this up shortly as part of the BOLT12 work, where I'll touch the PaymentDetails a lot anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants