Get binding generation & publishing ready for 0.1 release #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
5 times, most recently
from
6fea98d
to
527ecff
Compare
tnull
changed the title
tnull
changed the title
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
2 times, most recently
from
dbb0d0d
to
ff7e913
Compare
|
Rebased on #124. |
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
5 times, most recently
from
f21bd20
to
049d0e9
Compare
tnull
changed the title
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
5 times, most recently
from
9e40c70
to
bbb4c15
Compare
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
2 times, most recently
from
0c37836
to
7f6d70a
Compare
Merged
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
from
7f6d70a
to
1716da5
Compare
We already have `Node::spendable_onchain_balance` and `Node::total_onchain_balance` exposed, so the general `onchain_balance` is kind of redudant. As it is also not exposed (and not easily exposable) in bindings, we can make the bindings and Rust APIs more homogeneous by dropping the call. Plus, we probably should avoid exposing any BDK types in the public API until BDK 1.0 landed and we made the switch, as many breaking changes will be coming with it.
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
from
1716da5
to
9e9a76f
Compare
|
Rebased on main after #124 was merged. |
jurvis
approved these changes
Jun 20, 2023
jkczyz
reviewed
Jun 20, 2023
...in/ldk-node-android/lib/src/androidTest/kotlin/org/lightningdevkit/ldknode/AndroidLibTest.kt
Outdated
Show resolved
Hide resolved
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
from
9e9a76f
to
48d52d4
Compare
As we're using the `onchain` keyword everywhere in the API to discern onchain-operations (e.g., `send_to_onchain_address`, `spendable_onchain_balance`, etc.) we also align the funding API call here and rename `new_funding_address` to `new_onchain_address`.
Now that we split out UniFFI to its own feature, we can make use of the `missing_docs` lint again and enforce it in CI for release docs as well as private items.
.. and use a particular nightly rev for where it's not.
tnull
force-pushed
the
2023-05-get-bindings-release-ready
branch
from
48d52d4
to
7de04b7
Compare
Squashed fixups without further changes. |
jkczyz
reviewed
Jun 21, 2023
| print('Failed to read Package.swift file.', file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| package_file = original_package_file |
There was a problem hiding this comment.
Is the additional variable needed? @arik-so Do you have any insight?
jkczyz
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #124.Follow-up to #59.
Closes #73.
Here we'll add the final necessary steps to get bindings ready for the initial 'official' release.