Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify and update ChannelConfig #122

Merged

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Jun 9, 2023

This is useful/necessary to set forwarding fee rates, as well as allowing for overriding the dust HTLC exposure limit.

@tnull tnull changed the title Allow ways to specify and update ChannelConfig Allow to specify and update ChannelConfig Jun 9, 2023
... as by now `ChannelHandshakeLimits::their_to_self_delay` defaults to
2016 anyways.
@tnull tnull force-pushed the 2023-05-expose-update-channel-config branch from 057065a to ff59bc0 Compare June 13, 2023 18:52
@tnull
Copy link
Collaborator Author

tnull commented Jun 13, 2023

Rebased.

@tnull tnull mentioned this pull request Jun 13, 2023
47 tasks
@tnull tnull added this to the 0.1 milestone Jun 14, 2023
src/lib.rs Outdated Show resolved Hide resolved
@tnull tnull force-pushed the 2023-05-expose-update-channel-config branch from ff59bc0 to ba05dbf Compare June 15, 2023 17:56
Copy link

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash fixups.

This is useful/necessary to set forwarding fee rates, as well as
allowing for overriding the dust HTLC exposure limit.
@tnull tnull force-pushed the 2023-05-expose-update-channel-config branch from ba05dbf to 831a330 Compare June 15, 2023 18:00
@tnull
Copy link
Collaborator Author

tnull commented Jun 15, 2023

LGTM. Please squash fixups.

Squashed.

@tnull tnull merged commit 5dd2f6e into lightningdevkit:main Jun 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants