Allow to listen on and advertise multiple SocketAddr
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderwiederin
force-pushed
the
92-allow-multiple-listen
branch
from
5d352ce
to
6790a86
Compare
alexanderwiederin
force-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
4c401fc
to
fd3e74a
Compare
alexanderwiederin
force-pushed
the
92-allow-multiple-listen
branch
from
b26d129
to
598b161
Compare
tnull
reviewed
Nov 13, 2023
tnull
reviewed
Nov 13, 2023
tnull
reviewed
Nov 13, 2023
alexanderwiederin
force-pushed
the
92-allow-multiple-listen
branch
3 times, most recently
from
dec253a
to
758e614
Compare
tnull
reviewed
Nov 14, 2023
alexanderwiederin
force-pushed
the
92-allow-multiple-listen
branch
2 times, most recently
from
7d52e50
to
6d40944
Compare
tnull
reviewed
Nov 15, 2023
alexanderwiederin
force-pushed
the
92-allow-multiple-listen
branch
4 times, most recently
from
c3549f9
to
18f567c
Compare
|
Rebased and adapted python tests to set a list of Running the tests in the CI, we get: Running the test locally, returns a similar error, but on a different line. Will continue to look into this, but if you have an idea, let me know! |
tnull
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Rebased and adapted python tests to set multiple
listening_addresses.Running the tests in the CI, we get:
TMP DIR 1: /tmp/tmpj9y442xu_ldk_node_1 Node ID 1: 034edc368e2707c09293c2035cd7b197edfe5736bb55e55493374592797b376c2e TMP DIR 2: /tmp/tmpn11v_7gj_ldk_node_2 E/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/tempfile.py:860: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpj9y442xu_ldk_node_1'> _warnings.warn(warn_message, ResourceWarning) thread '<unnamed>' panicked at src/logger.rs:70:14: Failed to open log file: Os { code: 2, kind: NotFound, message: "No such file or directory" } note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace /home/runner/work/_temp/a1a4800b-6608-4c01-8400-1a6843ab90bd.sh: line 2: 6461 Aborted (core dumped) python3 -m unittest discover -s src/ldk_nodeRunning the test locally, returns a similar error, but on a different line.
Will continue looking into this, but if you have an idea, let me know!
Yes, this is what the Python tests put out when they panic (essentially we panic, shutdown, write some logs, while the Python test env already tries to cleanup the temporary folder). See the comment on why it fails.
alexanderwiederin
force-pushed
the
92-allow-multiple-listen
branch
from
18f567c
to
fe1ccab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #92
SocketAddr.random_configin testing to set two listening addresses.Also fixes a small typo in an error message