Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFFI bindings #25

Merged
merged 10 commits into from
May 9, 2023
Merged

UniFFI bindings #25

merged 10 commits into from
May 9, 2023

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Oct 20, 2022

Based on #9, #10, #11, #13, #52.

This PR provides the starting point for UniFFI bindings. Depending on how much code changes are required for the binding generation, we may want to move this to a separate repository.

@tnull tnull force-pushed the 2022-09-start-uniffi branch 7 times, most recently from 933cc5c to 7eb0707 Compare October 21, 2022 09:42
@tnull tnull mentioned this pull request Nov 15, 2022
@tnull tnull force-pushed the 2022-09-start-uniffi branch 2 times, most recently from 78e2f18 to f4df595 Compare December 13, 2022 13:14
@tnull
Copy link
Collaborator Author

tnull commented Dec 13, 2022

Rebased on current state of #11.

@tnull tnull force-pushed the 2022-09-start-uniffi branch from f4df595 to 45c7724 Compare December 13, 2022 14:00
@tnull tnull force-pushed the 2022-09-start-uniffi branch 3 times, most recently from b7622d9 to 4b449b4 Compare December 15, 2022 11:37
@tnull
Copy link
Collaborator Author

tnull commented Dec 15, 2022

Rebased on #11.

@tnull tnull force-pushed the 2022-09-start-uniffi branch 5 times, most recently from a364bb0 to 2d9fe37 Compare December 19, 2022 11:00
@tnull tnull force-pushed the 2022-09-start-uniffi branch 3 times, most recently from 8481816 to 1b70183 Compare January 11, 2023 12:54
@tnull tnull force-pushed the 2022-09-start-uniffi branch 2 times, most recently from 32d3675 to 4fcfebc Compare January 27, 2023 18:59
@tnull tnull force-pushed the 2022-09-start-uniffi branch from 7921080 to 40c5031 Compare January 27, 2023 20:50
@tnull tnull force-pushed the 2022-09-start-uniffi branch from 49f7f59 to dfad7f1 Compare April 25, 2023 09:20
@tnull
Copy link
Collaborator Author

tnull commented Apr 25, 2023

Squashed fixups and rebased. Dropped part of the last WIP commit, as this is getting too big anyways.

We should land this and then add CI bindings testing in a follow-up.

@tnull tnull force-pushed the 2022-09-start-uniffi branch from dfad7f1 to 13ab9b6 Compare April 26, 2023 17:45
@tnull
Copy link
Collaborator Author

tnull commented Apr 26, 2023

Rebased on main.

Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the "bindings generation support" commits generated from somewhere?

bindings/ldk_node.udl Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/test/functional_tests.rs Outdated Show resolved Hide resolved
src/types.rs Show resolved Hide resolved
src/types.rs Outdated Show resolved Hide resolved
src/io_utils.rs Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@tnull tnull force-pushed the 2022-09-start-uniffi branch 3 times, most recently from b4fecbb to 8cf01a0 Compare May 3, 2023 09:01
bindings/ldk_node.udl Show resolved Hide resolved
src/types.rs Show resolved Hide resolved
src/types.rs Outdated Show resolved Hide resolved
bindings/kotlin/ldk-node-android/lib/build.gradle.kts Outdated Show resolved Hide resolved
val address2 = node2.newFundingAddress()
println("Funding address 2: $address2")

//sendToAddress(address1, 100000u)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is commented out?

Copy link
Collaborator Author

@tnull tnull May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as the way I'm issuing commands to the bitcoind regtest node in the JVM version doesn't work on Android (no bitcoin-cli available there, and not even the Runtime JVM object I use to run the commands) . So it's still WIP how to actually integrate the Android library tests with a) any bitcoind/electrsd backend b) run them in the Android device simulator and c) run all of it in CI.

All of it will be a bunch of work that I don't expect to land in this PR, very likely not even for 0.1. I now dropped the commented-out parts and would defer any further changes to a dedicated follow-up.

src/error.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@tnull tnull force-pushed the 2022-09-start-uniffi branch 3 times, most recently from 58d6868 to ea53a29 Compare May 4, 2023 10:44
Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash fix-ups.

@tnull tnull force-pushed the 2022-09-start-uniffi branch from ea53a29 to cf92ff1 Compare May 8, 2023 19:24
@tnull
Copy link
Collaborator Author

tnull commented May 8, 2023

LGTM. Please squash fix-ups.

Squashed without further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants