Bump max inflight HTLC value to 100% if we're an LSPS2 client #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-02-bump-inflight-when-lsps-client
branch
3 times, most recently
from
997c571
to
7a64a76
Compare
Merged
jkczyz
reviewed
Feb 26, 2024
src/builder.rs
Outdated
Comment on lines
707
to
709
| // FIXME: When we're an LSPS2 client, set maximum allowed inbound HTLC value in flight | ||
| // to 100%. We should eventually be able to set this on a per-channel basis, but for | ||
| // now we just bump or default for all channels. |
There was a problem hiding this comment.
Should we note somewhere in user docs that this affects non-JIT channels?
There was a problem hiding this comment.
Hmm, I'd rather not honestly, as communicating what risks this entails requires to get super technical and arguably the inflight value is much too low for non-forwarding nodes anyways (and we can probably assume a node using LSPS2 JIT invoices won't be a central routing node in the network). Still, I want to get this fixed soon, hopefully even by 0.0.122.
tnull
force-pushed
the
2024-02-bump-inflight-when-lsps-client
branch
from
7a64a76
to
1723d09
Compare
When we're an LSPS2 client, the LSP might open the channel to us with a capacity only barely more than the initial payment size. We therefore need to be able to receive close to 100% of the channel size in a single HTLC. Here we therefore bump the default max HTLC value inflight config to 100%. We should eventually be able to set this on a per-channel basis, but for now we just bump the default for all channels.
tnull
force-pushed
the
2024-02-bump-inflight-when-lsps-client
branch
from
1723d09
to
2a85149
Compare
|
Force pushed with the following change: diff --git a/src/builder.rs b/src/builder.rs
index cfc6c59..cc0c9ad 100644
--- a/src/builder.rs
+++ b/src/builder.rs
@@ -707,5 +707,5 @@ fn build_with_store_internal<K: KVStore + Sync + Send + 'static>(
// FIXME: When we're an LSPS2 client, set maximum allowed inbound HTLC value in flight
// to 100%. We should eventually be able to set this on a per-channel basis, but for
- // now we just bump or default for all channels.
+ // now we just bump the default for all channels.
user_config.channel_handshake_config.max_inbound_htlc_value_in_flight_percent_of_channel =
100; |
jkczyz
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're an LSPS2 client, the LSP might open the channel to us with a capacity only barely more than the initial payment size. We therefore need to be able to receive close to 100% of the channel size in a single HTLC.
Here we therefore bump the default max HTLC value inflight config to 100%. We should eventually be able to set this on a per-channel basis, but for now we just bump or default for all channels.