Skip to content

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Jun 19, 2025

See #580

@tnull tnull requested a review from joostjager June 19, 2025 11:34
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jun 19, 2025

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull force-pushed the 2025-06-cut-0.6.1-main branch from f68b502 to 25fe5e3 Compare June 19, 2025 11:38
@tnull
Copy link
Collaborator Author

tnull commented Jun 19, 2025

Force-pushed minor fixup:

> git diff-tree -U2 f68b5024 25fe5e35
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 957ee157..fe613a07 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,5 +4,5 @@ type in bindings.

 ## Feature and API updates
-- The `Bolt11Invoice::description` description method is now exposed as
+- The `Bolt11Invoice::description` method is now exposed as
   `Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
   Swift standard method of same name (#576)

## Feature and API updates
- The `Bolt11Invoice::description` method is now exposed as
`Bolt11Invoice::invoice_description` in bindings, to avoid collisions with a
Swift standard method of same name (#576)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mention the "main" versions of these prs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, I think it still makes sense to cite the 'original' PRs, but we should probably settle on where PRs go first.

@tnull tnull force-pushed the 2025-06-cut-0.6.1-main branch from df31b1c to ec2b24d Compare June 19, 2025 12:18
@tnull tnull merged commit ff9782b into lightningdevkit:main Jun 19, 2025
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants