Set log target to module path #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `log!()` macro defaults to using the module path as the log target when no target is specified. Explicitly setting the log target to the module path enables better integration with other logging crates, such as `env_logger`, allowing them to filter logs by target (e.g., via `env_logger::Builder::parse_filters()`).
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
Jun 27, 2025
Collaborator
There was a problem hiding this comment.
I'm not sure I understand your commit message. Are you saying it's defaulting to the local module path rather than record.module_path? Could you provide a proper rationale for the change, i.e., why it is required and what the effect on the log output is exactly?
Also, note that this doesn't build currently.
andrei-21
force-pushed
the
feature/set-log-target
branch
from
b4065ee to
1199f7d
Compare
Contributor
Author
|
I updated the description and fixed the compilation problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
log!()macro defaults to using the module path as the log target when no target is specified.Explicitly setting the log target to the module path enables better integration with other logging crates,
such as
env_logger, allowing them to filter logs by target (e.g., viaenv_logger::Builder::parse_filters()).