Use [patch] instead of switching all the dependencies
#694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously added a bunch of commented-out `rust-lightning` dependencies in our `Cargo.toml` to be able to easily switch between `rust-lightning` locations. However, this is exactly what the `[patch]` command is for, which in particular also allows to patch a dependency for the whole tree, not only this one project. Therefore, we move the examples to a commented-out `patch` section.
|
👋 Thanks for assigning @joostjager as a reviewer! |
.. which might be necessary for it to be able to run successfully.
Collaborator
Author
|
Also added anther chore commit that elevates the weekly |
joostjager
approved these changes
Nov 5, 2025
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write |
Contributor
There was a problem hiding this comment.
Maybe run it hourly temporarily to see if this fixes it?
Collaborator
Author
There was a problem hiding this comment.
Well, no, after this is merged I can just manually run it in Github UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously added a bunch of commented-out
rust-lightningdependencies in ourCargo.tomlto be able to easily switch betweenrust-lightninglocations. However, this is exactly what the[patch]command is for, which in particular also allows to patch a dependency for the whole tree, not only this one project.Therefore, we move the examples to a commented-out
patchsection.