Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log facade and log4rs for logging. #44

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Feb 13, 2025

  • Pending Ldk-node upgrade, hence draft.

@@ -4,6 +4,8 @@ version = "0.1.0"
edition = "2021"

[dependencies]
log = "0.4.25"
log4rs = "1.3.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a quite a big dependency tree, also single-author stuff like https://github.com/sfackler/rust-log-mdc.
Are we sure there is no feasible alternative? Or do we even want to implement a bare bones logger ourselves, it's really straightforward (see the MockLogger in lightningdevkit/ldk-node#463).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants