Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: error adding ldk-swift to xcode project #120

Closed
reez opened this issue Oct 16, 2023 · 0 comments · Fixed by #121
Closed

package: error adding ldk-swift to xcode project #120

reez opened this issue Oct 16, 2023 · 0 comments · Fixed by #121

Comments

@reez
Copy link
Contributor

reez commented Oct 16, 2023

Describe the bug

User cannot add ldk-swift to Xcode project.

This is happening for ldk-swift 0.0.117 and main, but not 0.0.116.

Screenshot 2023-10-16 at 1 09 13 PM

To Reproduce

Steps to reproduce the behavior in Xcode:

  1. File -> Add Swift Package Dependencies
  2. Enter Package URL https://github.com/lightningdevkit/ldk-swift.git
  3. Dependency Rule -> Exact Version -> 0.0.117 or Dependency Rule -> Branch -> main
  4. Add Package
  5. See error "Invalid Manifest"
  6. Add Anyway
  7. See more specific errors in Navigator/IssueNavigator

Expected behavior
User can add ldk-swift to Xcode project when using version 0.0.117 or main.

Screenshots

main error

Screenshot 2023-10-16 at 1 06 39 PM Screenshot 2023-10-16 at 1 07 10 PM

0.0.116 success

Screenshot 2023-10-16 at 1 11 25 PM

0.0.117 error

Screenshot 2023-10-16 at 1 09 13 PM

Desktop (please complete the following information):

I did all of my testing (main, 0.0.117, 0.0.116) with two separate OS and Xcode for additional sanity checking.

macOS 15

  • Xcode 15.0 with iOS 17.0 minimum support

macOS 13

  • Xcode 14.3.1 with iOS 16.4 minimum support

Additional context
On 10/12/23 a user ran into a similar problem and posted about it in the LDK Discord. I followed up with him in the channel that I had run into this sort of error super recently and gave him the short term fix I used to get things working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant