Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning-0.0.104 fails to compile on Rust 1.60 beta due to ambiguous fmt call in ln/msgs.rs #1344

Closed
the8472 opened this issue Mar 2, 2022 · 3 comments
Closed

lightning-0.0.104 fails to compile on Rust 1.60 beta due to ambiguous fmt call in ln/msgs.rs #1344

the8472 opened this issue Mar 2, 2022 · 3 comments

Comments

@the8472
Copy link

the8472 commented Mar 2, 2022

A crater run found that the crate no longer compiles on Rust 1.60 beta (see rust-lang/rust#94507) due to a newly added trait impl in the standard library causes ambiguities in method resolution.

The regression has been deemed an acceptable minor change per RFC 1105.
It can be fixed by using fully qualified function call syntax to disambiguate the fmt call.
@TheBlueMatt
Copy link
Collaborator

Yes, we tried to open an issue upstream at rust-lang/rust#93599 and report it some time ago, see discussion there.

@the8472
Copy link
Author

the8472 commented Mar 2, 2022

Hah, I even commented there. Sorry for the noise as you already were aware.

@the8472 the8472 closed this as completed Mar 2, 2022
@TheBlueMatt
Copy link
Collaborator

All good, not your job to map names to projects.

@sr-gi sr-gi mentioned this issue Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBlueMatt @the8472