Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ChannelMonitor Eq #1912

Closed
TheBlueMatt opened this issue Dec 12, 2022 · 0 comments · Fixed by #1986
Closed

Expose ChannelMonitor Eq #1912

TheBlueMatt opened this issue Dec 12, 2022 · 0 comments · Fixed by #1986
Assignees
@TheBlueMatt
Milestone
0.0.114

Comments

@TheBlueMatt
Copy link
Collaborator

We currently implement it for our own testing, and we've had users ask for it for their testing, so probably best to expose it. dunno if it makes sense to expose as-is via the ParitlEq trait, or if we want a separate method for it so we can provide additional documentation.
@TheBlueMatt TheBlueMatt added this to the 0.0.114 milestone Dec 12, 2022
@TheBlueMatt TheBlueMatt mentioned this issue Dec 12, 2022
Closed
@benthecarman benthecarman mentioned this issue Dec 12, 2022
Closed
@TheBlueMatt TheBlueMatt self-assigned this Dec 18, 2022
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jan 26, 2023
@TheBlueMatt
Implement PartialEq for ChannelMonitor
d9dfc16 
It turns out `#[derive(PartialEq)]` will automatically bound the
`PartialEq` implementation by any bounds on the struct also being
`PartialEq`. This means to use an auto-derived `ChannelMonitor`
`PartialEq` the `EcdsaSigner` used must also be `PartialEq`, but
for the use-cases we have today for a `ChannelMonitor` `PartialEq`
it doesn't really matter - we use it internally in tests and
downstream users wanted similar test-only usage.

Fixes lightningdevkit#1912.
@TheBlueMatt TheBlueMatt mentioned this issue Jan 26, 2023
Merged
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Jul 24, 2023
@TheBlueMatt @optout21
Implement PartialEq for ChannelMonitor
b968c6c 
It turns out `#[derive(PartialEq)]` will automatically bound the
`PartialEq` implementation by any bounds on the struct also being
`PartialEq`. This means to use an auto-derived `ChannelMonitor`
`PartialEq` the `EcdsaSigner` used must also be `PartialEq`, but
for the use-cases we have today for a `ChannelMonitor` `PartialEq`
it doesn't really matter - we use it internally in tests and
downstream users wanted similar test-only usage.

Fixes lightningdevkit#1912.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueMatt TheBlueMatt

Labels
None yet
Projects
None yet
Milestone
0.0.114
1 participant
@TheBlueMatt