Skip to content

no-std version of create_phantom_invoice #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Jan 21, 2023 · 0 comments · Fixed by #1985
Closed

no-std version of create_phantom_invoice #1978

TheBlueMatt opened this issue Jan 21, 2023 · 0 comments · Fixed by #1985
Labels
good first issue Good for newcomers
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

Should be pretty easy, just gotta accept the current time as a parameter like we do for the create_Invoice_from_channelmanager_and_duration_since_epoch* functions. I really hate the cambrian explosion of functions in that file, so bonus points for cleaning it up, but it doesn't have to happen now.

@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Jan 21, 2023
@TheBlueMatt TheBlueMatt added this to the 0.0.114 milestone Jan 21, 2023
@TheBlueMatt TheBlueMatt reopened this Jan 21, 2023
Kurtsley added a commit to Kurtsley/rust-lightning that referenced this issue Jan 23, 2023
Kurtsley added a commit to Kurtsley/rust-lightning that referenced this issue Jan 25, 2023
Kurtsley added a commit to Kurtsley/rust-lightning that referenced this issue Jan 26, 2023
Kurtsley added a commit to Kurtsley/rust-lightning that referenced this issue Jan 27, 2023
Kurtsley added a commit to Kurtsley/rust-lightning that referenced this issue Jan 27, 2023
…it#1978

Replace current_timestamp call with no-std duration_from_epoch
TheBlueMatt added a commit that referenced this issue Jan 30, 2023
Remove std::SystemTime from create_phantom_invoice, ref #1978
valentinewallace pushed a commit to valentinewallace/rust-lightning that referenced this issue Feb 3, 2023
…it#1978

Replace current_timestamp call with no-std duration_from_epoch
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Jul 24, 2023
…it#1978

Replace current_timestamp call with no-std duration_from_epoch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant