Improve block connection logging

[TheBlueMatt]

We regularly get users reporting issues with block sync (cause our API is a bit confusing, which desperately needs fixing by exposing the block sync crates to bindings users). These are quite hard to debug from our logs as our logs just aren't super detailed. We should log txids connected/confirmed as long as the list is small-ish, and maybe also log when we add things to the filter.

[Sharmalm]

can i try this one?

[TheBlueMatt]

Go for it. Should require carefully reading the block and transaction connection codepaths from ChannelManager and ChainMonitor all the way down and just ensuring that everything that happens gets logged but only once.

[Sharmalm]

Could i get more information about codepath from channelManager and Chainmonitor , and how channelmaanger is accesing txids from chainmonitor .
and also here 'txid' mentioned here is transaction id of funding transaction?

[TheBlueMatt]

They're fully separate, called independently from LDK users' code.

[Sharmalm]

Ok ,
during constructing a channel message flow is - alice : open_channel , Bob : accept channel, alice : funding_created , bob : funding_signed and after funding_signed message funding_transaction broadcasted . so i have to log after funding signed message .

[TheBlueMatt]

This issue is about the block connection, though, not the message handling flow. Block connection happens via transactions_confirmed/transactions_unconfirmed/block_connected/block_disconnected.