Add another test for `max_total_routing_fee_msat` #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tnull opened this issue Sep 25, 2023 · 0 comments · Fixed by #2417

Assignees

Contributor

tnull commented Sep 25, 2023

In #2417 (review) Matt requested an additional test case

I'd like to see a test of the overpayment handling in payment_tests. Specifically, a test where we send a payment for X with a route that does an MPP payment of X + Y to meet some htlc_minimum_msat. Then, on retry if one path fails, we ignore the Y in the remaining fee and just count it as an amount we don't need to pay. I think its correct currently, but don't want to regress.

Working on it.

tnull self-assigned this

tnull mentioned this issue

Add config option to set maximum total routing fee #2417

Merged

TheBlueMatt closed this as completed in #2417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment