Skip to content

Dont apply NetworkUpdate::ChannelUpdate in an observable way #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Sep 25, 2023 · 2 comments · Fixed by #2666
Closed

Dont apply NetworkUpdate::ChannelUpdate in an observable way #2598

TheBlueMatt opened this issue Sep 25, 2023 · 2 comments · Fixed by #2666
Assignees
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

If we apply ChannelUpdate to our graph in an observable way, the node that generated that update can detect that we were the sender of the payment, making a rather substantial privacy leak. We should instead keep any updates local to the given payment.

@TheBlueMatt TheBlueMatt added this to the 0.0.118 milestone Sep 25, 2023
@tnull tnull self-assigned this Oct 12, 2023
@tnull
Copy link
Contributor

tnull commented Oct 16, 2023

Mh, after having a closer look at this it seems we can just avoid applying the updates and be done with it, as we avoid reusing any PaymentParameters::previously_failed_channels anyways?

That is, it doesn't make a lot of sense handing the channel updates through, verifying them, and accounting for them in routing if we'd never end up using the failed, updated channels anyways?

@TheBlueMatt
Copy link
Collaborator Author

Yea, makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants