Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fee_satoshis when replying to quick close (as non-opener), not max_fee_satoshis #3014

Open
rustyrussell opened this issue Apr 23, 2024 · 0 comments
Open

Use fee_satoshis when replying to quick close (as non-opener), not max_fee_satoshis #3014

rustyrussell opened this issue Apr 23, 2024 · 0 comments
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@rustyrussell
Copy link

fee_satoshis is the amount they suggest, so you should only respond with a different amount if it's disagreeable. max_fee_satoshis is the worst case for them, so choosing it is fairly anti-social.

The spec does not actually spell this out, unfortunately, but when combined with CLN's "YOLO ignore-fee-rates" option (which sets the feerate to 0xFFFFFFF), the result is stupidly expensive:

ElementsProject/lightning#7242

(And yes, v3 close fixes this, but this is deployed now...)
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 23, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
0567ac4 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 23, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
7ae1816 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 7, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
0ee1f8f 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 9, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
fc45c1f 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 21, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
ed92370 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 22, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
f040f58 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 22, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
a86e31a 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 22, 2024
@rustyrussell
lightningd: don't ignore fee limits on mutual close.
c545f57 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#7242
endothermicdev pushed a commit to ElementsProject/lightning that referenced this issue May 22, 2024
@rustyrussell @endothermicdev
lightningd: don't ignore fee limits on mutual close.
877df5a 
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)!

It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented.

Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: #7242
@TheBlueMatt TheBlueMatt added the Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBlueMatt @rustyrussell