Skip to content

Logging Interface #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Jul 20, 2018 · 3 comments
Closed

Logging Interface #54

TheBlueMatt opened this issue Jul 20, 2018 · 3 comments
Labels
good first issue Good for newcomers

Comments

@TheBlueMatt
Copy link
Collaborator

We need to convert the few printlns we have to some kind of user-provided logging interface, as well as add a ton of additional logs. I think its fine if we just make it another Arc<trait> that gets passed around everywhere and we call it directly with lines. Would be nice to avoid the format!() overhead when we dont need it, so maybe we can provide build options to turn off debug logging and avoid most of it?
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Jul 20, 2018
@TheBlueMatt
Copy link
Collaborator Author

Tagged good first issue as at least writing the trait and passing around the Arcs everywhere should be easy, other bits can come later.

@ariard
Copy link

ariard commented Jul 23, 2018

Just started to working on this, something like a lightweight of crate log, which use compile time filters

ariard pushed a commit to ariard/rust-lightning that referenced this issue Jul 26, 2018
Logging interface
f1a35a2 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Jul 26, 2018
Logging interface
6736566 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Jul 28, 2018
Logging interface
e5c6c54 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Jul 28, 2018
Logging interface
d2ab686 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Jul 29, 2018
Logging interface
3356d6e 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Jul 29, 2018
Logging interface
36273c9 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Jul 31, 2018
Logging interface
2f9b8a7 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering. Latter can't be superior than former.
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Aug 1, 2018
Logging interface
51482c5 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering.
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Aug 12, 2018
Logging interface
f97ef28 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering.
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Aug 16, 2018
Logging interface
932c81c 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering.
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Aug 16, 2018
Logging interface
b1a1d3d 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering.
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Aug 16, 2018
Logging interface
951e7d5 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering.
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Aug 17, 2018
Logging interface
19c84c5 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering.
Issue lightningdevkit#54
ariard pushed a commit to ariard/rust-lightning that referenced this issue Aug 17, 2018
Logging interface
0029f04 
Implement error, warn, info, debug and trace macros, internally calling
an instance of Logger, and passing it to every main structures
Build-time or client-side filtering.
Issue lightningdevkit#54
@TheBlueMatt
Copy link
Collaborator Author

We still need to go through and add a bunch of log traces everywhere, but I'm gonna call this closed by #91 :).

carlaKC pushed a commit to carlaKC/rust-lightning that referenced this issue Aug 9, 2023
@TheBlueMatt
Merge pull request lightningdevkit#54 from TheBlueMatt/main
24da657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBlueMatt @ariard