Skip to content

ChannelManager::force_close_channel does not fail on random channel_id #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sr-gi opened this issue Jan 12, 2021 · 2 comments · Fixed by #777
Closed

ChannelManager::force_close_channel does not fail on random channel_id #773

sr-gi opened this issue Jan 12, 2021 · 2 comments · Fixed by #777

Comments

@sr-gi
Copy link
Contributor

sr-gi commented Jan 12, 2021 •
edited
Loading

ChannelManager::force_close_channel attempts to close any given channel_id, even if the latter is unknown by the manager.

This contrasts with ChannelManager::close_channel, where a errors::APIError::ChannelUnavailable will be raised.

Having the same interface regarding unknown channels by both methods feels like the way to go, so I think force_close_channel should be updated.
@sr-gi
Copy link
Contributor Author

sr-gi commented Jan 12, 2021

I can tackle this issue if there's consensus on the update btw.

@TheBlueMatt
Copy link
Collaborator

I can tackle this issue if there's consensus on the update btw.

I'd say go for it.

@sr-gi sr-gi mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makes ChannelManager::force_close_channel fail for unknown chan_ids sr-gi/rust-lightning
2 participants
@TheBlueMatt @sr-gi