Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Compression Algorithm Advertisement #1015

Closed

Conversation

TheBlueMatt
Copy link
Collaborator

As specified by lightning/bolts#825

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1015 (28b9726) into main (1beccf1) will increase coverage by 0.03%.
The diff coverage is 98.40%.

❗ Current head 28b9726 differs from pull request most recent head 03ceb33. Consider uploading reports for the commit 03ceb33 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
+ Coverage   90.29%   90.32%   +0.03%     
==========================================
  Files          70       70              
  Lines       36624    36626       +2     
==========================================
+ Hits        33070    33084      +14     
+ Misses       3554     3542      -12     
Impacted Files Coverage Δ
lightning/src/routing/network_graph.rs 91.33% <91.30%> (-0.02%) ⬇️
lightning-background-processor/src/lib.rs 94.95% <100.00%> (-0.05%) ⬇️
lightning/src/ln/chanmon_update_fail_tests.rs 97.65% <100.00%> (ø)
lightning/src/ln/channelmanager.rs 83.73% <100.00%> (+0.04%) ⬆️
lightning/src/ln/features.rs 99.42% <100.00%> (-0.06%) ⬇️
lightning/src/ln/functional_test_utils.rs 95.13% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 97.27% <100.00%> (-0.04%) ⬇️
lightning/src/ln/msgs.rs 86.57% <100.00%> (+0.23%) ⬆️
lightning/src/ln/payment_tests.rs 99.10% <100.00%> (ø)
lightning/src/ln/peer_handler.rs 49.77% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1beccf1...03ceb33. Read the comment docs.

@TheBlueMatt TheBlueMatt force-pushed the 2021-07-compression-algos branch from 9957835 to 00dd384 Compare July 24, 2021 18:34
@TheBlueMatt TheBlueMatt force-pushed the 2021-07-compression-algos branch 3 times, most recently from 70a44e2 to 03ceb33 Compare November 13, 2021 17:25
@TheBlueMatt TheBlueMatt force-pushed the 2021-07-compression-algos branch from 03ceb33 to e85288e Compare November 30, 2021 21:53
@TheBlueMatt
Copy link
Collaborator Author

Closing cause it looks like the BOLT PR isn't gonna go anywhere, ideally we'll end up with lightning/bolts#981 instead and we don't have to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant