Use common macro and local channel view for routing in tests #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2021-10-test-routing-via-macro
branch
2 times, most recently
from
6a54860 to
655cca1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
- Coverage 90.67% 90.60% -0.07%
==========================================
Files 66 66
Lines 34689 34515 -174
==========================================
- Hits 31454 31274 -180
- Misses 3235 3241 +6
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2021-10-test-routing-via-macro
branch
from
655cca1 to
b3fd1f8
Compare
TheBlueMatt
force-pushed
the
2021-10-test-routing-via-macro
branch
from
b3fd1f8 to
1ebbf9b
Compare
|
Now based on #1116 to avoid conflicting too much with ongoing work. |
This moves towards standardizing the get_route calls somewhat in tests to avoid the huge "change every line of tests to a new get_route API" commits in the future. This isn't meant to be exhaustive, and only tackled the very trivial cases, but progress is progress.
TheBlueMatt
force-pushed
the
2021-10-test-routing-via-macro
branch
from
1ebbf9b to
41ca433
Compare
arik-so
approved these changes
Oct 13, 2021
|
Gonna wait and see what happens with #1120 first. |
|
#1120 was basically a better version of this and landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves towards standardizing the get_route calls somewhat in
tests to avoid the huge "change every line of tests to a new
get_route API" commits in the future.
This isn't meant to be exhaustive, and only tackled the very
trivial cases, but progress is progress.