Skip to content

Drop honggfuzz arbitrary dependency to meet MSRV #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #1687 (7223f70) into main (99123cd) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   90.87%   90.84%   -0.03%     
==========================================
  Files          85       85              
  Lines       45948    45948              
  Branches    45948    45948              
==========================================
- Hits        41754    41742      -12     
- Misses       4194     4206      +12     
Impacted Files Coverage Δ
lightning/src/chain/onchaintx.rs 94.02% <0.00%> (-0.92%) ⬇️
lightning/src/ln/functional_tests.rs 96.96% <0.00%> (-0.15%) ⬇️
lightning/src/util/events.rs 39.77% <0.00%> (+0.27%) ⬆️
lightning-net-tokio/src/lib.rs 77.67% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dunxen
Copy link
Contributor

dunxen commented Aug 30, 2022

Also needs an update for lightning-invoice/fuzz/ci-fuzz.sh looks like it.

@TheBlueMatt
Copy link
Collaborator Author

Ah, thanks.

@TheBlueMatt TheBlueMatt merged commit 0624cf9 into lightningdevkit:main Aug 30, 2022
uncomputable referenced this pull request in BlockstreamResearch/rust-simplicity Aug 31, 2022
7372460 Fix fuzzing (Christian Lewe)

Pull request description:

  Drops honggfuzz dependency `arbitrary` to meet MSRV. `arbitrary` 1.1.3 introduced `array_from_fn`, which is stable from Rust 1.63.0.

  See [https://github.com/lightningdevkit/rust-lightning/pull/1687](https://github.com/lightningdevkit/rust-lightning/pull/1687).

ACKs for top commit:
  apoelstra:
    ACK 7372460

Tree-SHA512: 4d3d5afa6f2e7ce101a93ff07b3d77d9df494eed1aae2cb17deca23b7a5cbea665f1cdda86c9b1b06e727a7d1ad670ae999c86fa44420fac5f1f5ff1d0aefb0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants