Chan_utils helpers visibility relaxation #1839

ariard · 2022-11-08T17:58:51Z

See: https://gitlab.com/lightning-signer/validating-lightning-signer/-/blob/main/lightning-signer-core/src/tx/script.rs#L76

Allowing upstream projects to reuse our BOLT-compliant helpers reduce for them the risk of incompatibility or non-propagating transactions bugs.

codecov-commenter · 2022-11-08T18:21:23Z

Codecov Report

Base: 90.77% // Head: 91.99% // Increases project coverage by +1.21% 🎉

Coverage data is based on head (9978e1c) compared to base (505102d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9978e1c differs from pull request most recent head 605d30e. Consider uploading reports for the commit 605d30e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1839      +/-   ##
==========================================
+ Coverage   90.77%   91.99%   +1.21%     
==========================================
  Files          87       90       +3     
  Lines       47595    59062   +11467     
  Branches    47595    59062   +11467     
==========================================
+ Hits        43204    54332   +11128     
- Misses       4391     4730     +339

Impacted Files	Coverage Δ
lightning/src/ln/chan_utils.rs	`93.97% <100.00%> (-0.02%)`	⬇️
lightning/src/util/events.rs	`34.91% <0.00%> (-2.72%)`	⬇️
lightning/src/chain/mod.rs	`66.66% <0.00%> (-1.52%)`	⬇️
lightning/src/lib.rs	`100.00% <0.00%> (ø)`
lightning/src/ln/reorg_tests.rs	`100.00% <0.00%> (ø)`
lightning/src/util/string.rs	`100.00% <0.00%> (ø)`
lightning/src/offers/offer.rs	`94.56% <0.00%> (ø)`
lightning/src/ln/reload_tests.rs	`95.24% <0.00%> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.72% <0.00%> (+0.05%)`	⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

lightning/src/ln/chan_utils.rs

wpaulino

What about the other TODOs like ANCHOR_OUTPUT_VALUE_SATOSHI and get_delayed_redeemscript?

lightning/src/ln/chan_utils.rs

ariard · 2022-11-10T16:14:09Z

Updated at b57e19f

The last push increase the visibility of few other const encapsulating protocol-level values.

What about the other TODOs like ANCHOR_OUTPUT_VALUE_SATOSHI and get_delayed_redeemscript?

I think our ANCHOR_OUTPUT_VALUE_SATOSHI is already public and get_delayed_redeeemscript is logically equivalent to get_to_countersignatory_with_anchors_redeemscript(). The further cleanup should be on VLS side.

wpaulino · 2022-11-10T19:08:22Z

CI is failing now since the now public consts need docs.

ariard · 2022-11-11T01:11:36Z

Hope CI should be happy at 264bf5f

lightning/src/ln/chan_utils.rs

TheBlueMatt · 2022-11-11T01:28:30Z

lightning/src/ln/msgs.rs

@@ -47,7 +47,7 @@ use crate::util::ser::{BigSize, LengthReadable, Readable, ReadableArgs, Writeabl
 use crate::ln::{PaymentPreimage, PaymentHash, PaymentSecret};

 /// 21 million * 10^8 * 1000
-pub(crate) const MAX_VALUE_MSAT: u64 = 21_000_000_0000_0000_000;
+pub const MAX_VALUE_MSAT: u64 = 21_000_000_0000_0000_000;


This also belongs in rust-bitcoin, not here.

It is though currently it's requiring a useless Network argument, sounds a legacy from multi-chain support of the library. I think downstream should be changed first to drop the argument: https://github.com/rust-bitcoin/rust-bitcoin/blob/1d0b0e6ed8e80767fef9b00a38c9e5fefc34baa0/bitcoin/src/blockdata/constants.rs#L63

Sure, but either way we shouldn't be exporting fundamental Bitcoin constants from rust-lightning.

Dropping the export for now and seeing with downstream to remove the argument.

ariard · 2022-11-12T01:18:03Z

Letting it at 264bf5f, if we would like to change downstream first or take the method as it is.

ariard · 2022-11-16T23:27:54Z

Updated at 9978e1c. PR is pending on this unsolved comment: #1839 (comment)

64495cc Drop Network arg from max_money() (Antoine Riard) Pull request description: Amount of coins available stay in the same across Bitcoin network: signet, testnet, mainet. From my understanding this is a leftover from some potential multi-chain support. For more context: lightningdevkit/rust-lightning#1839 (comment) If there is already an existent PR, it can be closed, however didn't find one. ACKs for top commit: apoelstra: ACK 64495cc tcharding: ACK 64495cc Tree-SHA512: 929011ee73c5eda903fb0140438ed5e88c8f5b7378036a87a6a660a8b9138bf204bf59a0ba822c0cd98e37e97d2d0dbbf8c9893a834da9acdf817ba43a5ed5b6

ariard · 2022-11-22T23:41:57Z

Updated at 6d61555

lightning/src/ln/chan_utils.rs

ariard · 2022-11-23T22:47:01Z

Updated at 0c614b7

TheBlueMatt

Some docs are confusing but LGTM.

lightning/src/ln/chan_utils.rs

ariard · 2022-11-30T00:52:17Z

Updated at 605d30e.

TheBlueMatt reviewed Nov 8, 2022

View reviewed changes

lightning/src/ln/chan_utils.rs Outdated Show resolved Hide resolved

wpaulino reviewed Nov 8, 2022

View reviewed changes

lightning/src/ln/chan_utils.rs Outdated Show resolved Hide resolved

ariard force-pushed the 2022-11-increase-visibility-helpers branch from 01565ec to b57e19f Compare November 10, 2022 16:08

ariard changed the title ~~Two minors chan_utils scripts helpers visibility relaxation~~ Chan_utils helpers visibility relaxation + const cleanups Nov 10, 2022

ariard force-pushed the 2022-11-increase-visibility-helpers branch from b57e19f to dd605f8 Compare November 10, 2022 16:12

ariard changed the title ~~Chan_utils helpers visibility relaxation + const cleanups~~ Chan_utils helpers visibility relaxation Nov 10, 2022

ariard force-pushed the 2022-11-increase-visibility-helpers branch from dd605f8 to 264bf5f Compare November 11, 2022 01:10

TheBlueMatt reviewed Nov 11, 2022

View reviewed changes

ariard force-pushed the 2022-11-increase-visibility-helpers branch from 264bf5f to 9978e1c Compare November 16, 2022 23:26

ariard force-pushed the 2022-11-increase-visibility-helpers branch 2 times, most recently from f535c96 to 6d61555 Compare November 22, 2022 23:41

wpaulino reviewed Nov 23, 2022

View reviewed changes

lightning/src/ln/chan_utils.rs Outdated Show resolved Hide resolved

lightning/src/ln/chan_utils.rs Show resolved Hide resolved

lightning/src/ln/chan_utils.rs Outdated Show resolved Hide resolved

ariard force-pushed the 2022-11-increase-visibility-helpers branch from 6d61555 to 0c614b7 Compare November 23, 2022 22:46

wpaulino previously approved these changes Nov 24, 2022

View reviewed changes

TheBlueMatt reviewed Nov 24, 2022

View reviewed changes

lightning/src/ln/chan_utils.rs Outdated Show resolved Hide resolved

lightning/src/ln/chan_utils.rs Outdated Show resolved Hide resolved

lightning/src/ln/chan_utils.rs Outdated Show resolved Hide resolved

Antoine Riard added 3 commits November 29, 2022 19:50

Increase visibility of protocol-level consts

2e4fab0

Increase visibility of script helper

263d76e

Remove get_p2wpkh_redeemscript in favor of lib helper

605d30e

ariard dismissed wpaulino’s stale review via 605d30e November 30, 2022 00:51

ariard force-pushed the 2022-11-increase-visibility-helpers branch from 0c614b7 to 605d30e Compare November 30, 2022 00:51

TheBlueMatt approved these changes Nov 30, 2022

View reviewed changes

TheBlueMatt assigned wpaulino Nov 30, 2022

wpaulino approved these changes Nov 30, 2022

View reviewed changes

TheBlueMatt merged commit 2f0ddf0 into lightningdevkit:main Nov 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chan_utils helpers visibility relaxation #1839

Chan_utils helpers visibility relaxation #1839

ariard commented Nov 8, 2022

codecov-commenter commented Nov 8, 2022 •

edited

Loading

wpaulino left a comment

ariard commented Nov 10, 2022

wpaulino commented Nov 10, 2022

ariard commented Nov 11, 2022

TheBlueMatt Nov 11, 2022

ariard Nov 12, 2022 •

edited

Loading

TheBlueMatt Nov 15, 2022

ariard Nov 16, 2022

ariard commented Nov 12, 2022

ariard commented Nov 16, 2022

ariard commented Nov 22, 2022

ariard commented Nov 23, 2022

TheBlueMatt left a comment

ariard commented Nov 30, 2022

Chan_utils helpers visibility relaxation #1839

Chan_utils helpers visibility relaxation #1839

Conversation

ariard commented Nov 8, 2022

codecov-commenter commented Nov 8, 2022 • edited Loading

Codecov Report

wpaulino left a comment

Choose a reason for hiding this comment

ariard commented Nov 10, 2022

wpaulino commented Nov 10, 2022

ariard commented Nov 11, 2022

TheBlueMatt Nov 11, 2022

Choose a reason for hiding this comment

ariard Nov 12, 2022 • edited Loading

Choose a reason for hiding this comment

TheBlueMatt Nov 15, 2022

Choose a reason for hiding this comment

ariard Nov 16, 2022

Choose a reason for hiding this comment

ariard commented Nov 12, 2022

ariard commented Nov 16, 2022

ariard commented Nov 22, 2022

ariard commented Nov 23, 2022

TheBlueMatt left a comment

Choose a reason for hiding this comment

ariard commented Nov 30, 2022

codecov-commenter commented Nov 8, 2022 •

edited

Loading

ariard Nov 12, 2022 •

edited

Loading