-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct async lightning-background-processor
exit check docs
#1843
Correct async lightning-background-processor
exit check docs
#1843
Conversation
Codecov ReportBase: 90.74% // Head: 90.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 90.74% 90.71% -0.04%
==========================================
Files 87 87
Lines 47364 47364
Branches 47364 47364
==========================================
- Hits 42980 42965 -15
- Misses 4384 4399 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
let mut should_continue = true; | ||
let mut should_break = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should be explicit and use an enum to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we're gonna have this bug twice :). As with this case, I think a user who implements it wrong should see pretty quick that its wrong, though I agree in the future we may consider doing enums more aggressively rather than bools.
The check to stop the background processor is true -> break, not false -> break. This simply updates the docs and leaves the code as-is.
2a8dd07
to
71739db
Compare
The check to stop the background processor is true -> break, not false -> break. This simply updates the docs and leaves the code as-is.