Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main build #1928

Merged

Conversation

valentinewallace
Copy link
Contributor

There was a silent conflict between #1923 and #1910

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 90.76% // Head: 90.75% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1ded1d2) compared to base (e64ebe8).
Patch coverage: 65.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.02%     
==========================================
  Files          96       96              
  Lines       50073    50077       +4     
  Branches    50073    50077       +4     
==========================================
- Hits        45451    45447       -4     
- Misses       4622     4630       +8     
Impacted Files Coverage Δ
lightning-background-processor/src/lib.rs 95.42% <ø> (ø)
lightning-invoice/src/utils.rs 97.76% <ø> (ø)
lightning/src/ln/chan_utils.rs 93.56% <ø> (ø)
lightning/src/ln/channel.rs 88.76% <0.00%> (-0.10%) ⬇️
lightning/src/ln/functional_test_utils.rs 93.73% <ø> (ø)
lightning/src/ln/functional_tests.rs 96.97% <ø> (+0.06%) ⬆️
lightning/src/ln/inbound_payment.rs 93.49% <ø> (ø)
lightning/src/ln/onion_route_tests.rs 97.64% <ø> (ø)
lightning/src/ln/outbound_payment.rs 89.18% <ø> (ø)
lightning/src/ln/payment_tests.rs 98.73% <ø> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinewallace valentinewallace merged commit cbbf84b into lightningdevkit:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants