Fix XXXs that slipped into router and handle HTLCFailCHannelUpdates #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuntai
reviewed
Oct 24, 2018
| if *is_permanent { | ||
| if let Some(chan) = network.channels.remove(short_channel_id) { | ||
| Self::remove_channel_in_nodes(&mut network.nodes, &chan, *short_channel_id); | ||
| } |
Contributor
There was a problem hiding this comment.
+ MAY TODO: if the announced node no longer has any associated open channels:
+ MAY prune nodes added through node_announcement messages from their local view.
?
Collaborator
Author
There was a problem hiding this comment.
remove_channel_in_nodes removes the node if there are no channels left.
Collaborator
Author
|
Gonna merge this to get travis working again. Its obviously not complete and adds some TODOs, but thats ok. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I usually use XXXs to indicate TODOs pre-commit/merge, but things are kinda in a rush for 0.0.6...oh well.