Add PaymentFailReason enum for fail_htlc_backwards #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to indicate fail reason after a PaymentReceived event
yuntai
force-pushed
the
2018-10-paymentfail
branch
from
34a9dff to
f133554
Compare
Collaborator
|
Looks good. Can you also add documentation to the PaymentReceived event that describes that users have to fail payments that have a value out of bounds? |
Contributor
Author
|
Documentation added. |
Collaborator
|
Will take as #224. |
TheBlueMatt
added a commit
that referenced
this pull request
Oct 26, 2018
#221 with a few trailing spaces removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to indicate failure reason after a PaymentReceived event.
and set onion error code to unknown_payment_hash or incorrect_payment_amount.
The test will come with the sequel of #219.