Move channel_reestablish messages to the simple message fuzzer
#2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 16d0f2f the `ChannelReestablish` messages was converted to the `impl_writeable_msg` serialization macro which handles a TLV stream suffix. In the case of our fuzzers, this implies we need to use the `test_msg_simple` checker rather than the `test_msg` one. `test_msg` checks that any bytes which were read must be present when we write the message back out, which is useful for gossip processing, however if we don't store ignored TLVs we cannot possibly meet the requirements. Instead, `test_msg_simple` only ensures that, if we serialized the message we can round-trip it exactly, i.e. at least the fields we understand round-trip.
|
Oh, right, I knew I'd seen this patch somewhere lol. I'm fine to leave it for that if we land that tomorrow, its just broken on main and CI is randomly failing. |
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2266 +/- ##
==========================================
- Coverage 91.50% 91.48% -0.02%
==========================================
Files 104 104
Lines 52087 52087
Branches 52087 52087
==========================================
- Hits 47660 47652 -8
- Misses 4427 4435 +8 ☔ View full report in Codecov by Sentry. |
|
Eh, lets just land #1794 tomorrow. |
|
Ugh, sorry about this. Should have copied it over. But I've addressed feedback in #1794 so hopefully good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 16d0f2f the
ChannelReestablishmessages was converted to theimpl_writeable_msgserialization macro which handles a TLV stream suffix. In the case of our fuzzers, this implies we need to use thetest_msg_simplechecker rather than thetest_msgone.test_msgchecks that any bytes which were read must be present when we write the message back out, which is useful for gossip processing, however if we don't store ignored TLVs we cannot possibly meet the requirements.Instead,
test_msg_simpleonly ensures that, if we serialized the message we can round-trip it exactly, i.e. at least the fields we understand round-trip.