Avoid persisting on same counterparty's ChannelUpdate #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
force-pushed
the
no-persist-same-channel-update
branch
from
00da3fc to
1ea4843
Compare
TheBlueMatt
previously approved these changes
Sep 28, 2023
G8XSU
reviewed
Sep 28, 2023
wpaulino
force-pushed
the
no-persist-same-channel-update
branch
from
1ea4843 to
511b580
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2617 +/- ##
==========================================
- Coverage 89.00% 88.97% -0.04%
==========================================
Files 112 112
Lines 86273 86355 +82
Branches 86273 86355 +82
==========================================
+ Hits 76791 76837 +46
- Misses 7248 7284 +36
Partials 2234 2234
☔ View full report in Codecov by Sentry. |
valentinewallace
previously approved these changes
Sep 29, 2023
Some nodes may rebroadcast their `ChannelUpdate` to their counterparty on every connection establishment, which leads to us doing an additional persist most of the time when nothing has changed. Now, we'll only persist if we receive an update that changes anything.
wpaulino
force-pushed
the
no-persist-same-channel-update
branch
from
511b580 to
c8c5354
Compare
TheBlueMatt
approved these changes
Sep 29, 2023
valentinewallace
approved these changes
Sep 29, 2023
G8XSU
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nodes may rebroadcast their
ChannelUpdateto their counterparty on every connection establishment, which leads to us doing an additional persist most of the time when nothing has changed. Now, we'll only persist if we receive an update that changes anything.Fixes #2616.