Skip to content

Publicize all UnsignedNodeAnnouncement fields. #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Mar 19, 2024

This is necessary for RGSS tests to create new announcements.

This is necessary for RGSS tests to create new announcements.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (2c9dbb9) to head (5f2b04b).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2948      +/-   ##
==========================================
+ Coverage   89.18%   89.20%   +0.02%     
==========================================
  Files         117      117              
  Lines       95541    95541              
  Branches    95541    95541              
==========================================
+ Hits        85205    85226      +21     
+ Misses       7840     7823      -17     
+ Partials     2496     2492       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, exactly what we did elsewhere. No need to burden another reviewer with this one.

@TheBlueMatt TheBlueMatt merged commit e4b6a50 into lightningdevkit:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants