Ignore channel updates in onion errors #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
force-pushed
the
2024-05-ignore-onion-err-chan-upd
branch
from
590262d to
124d79e
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3083 +/- ##
==========================================
+ Coverage 89.88% 90.20% +0.32%
==========================================
Files 117 117
Lines 96958 99869 +2911
Branches 96958 99869 +2911
==========================================
+ Hits 87146 90090 +2944
+ Misses 7268 7198 -70
- Partials 2544 2581 +37 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
reviewed
May 28, 2024
A new import will be added in the next commit.
valentinewallace
force-pushed
the
2024-05-ignore-onion-err-chan-upd
branch
from
124d79e to
7c874d7
Compare
TheBlueMatt
reviewed
May 28, 2024
See previous commit.
valentinewallace
force-pushed
the
2024-05-ignore-onion-err-chan-upd
branch
from
7c874d7 to
abb53d1
Compare
|
Squashed. |
TheBlueMatt
approved these changes
May 31, 2024
jkczyz
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still write channel updates out for the time being.
Closes #3044. #FF