Implement Readable for Bolt12Invoice
#3143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In c13b6d8 and fc14495 we implemented `Readable` for `Refund` and `Offer`s, but didn't do so for `Bolt12Invoice`. Because `Bolt12Invoice`s are not serializable to strings, we generally expect users to read and write them as byte arrays, and currently expose this via `TryFrom<Vec<u8>>`. This is fine, but there's no reason to not implement `Readable` as well, and it saves having to implement `TryFrom` in bindings.
jkczyz
reviewed
Jun 25, 2024
| @@ -1160,6 +1160,13 @@ impl TryFrom<Vec<u8>> for Bolt12Invoice { | |||
| } | |||
| } | |||
|
|
|||
| impl Readable for Bolt12Invoice { | |||
There was a problem hiding this comment.
This is already implemented on line 1122 as part of #3078.
There was a problem hiding this comment.
Oh sorry, I missed that 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c13b6d8 and
fc14495 we implemented
ReadableforRefundandOffers, but didn't do so forBolt12Invoice.Because
Bolt12Invoices are not serializable to strings, we generally expect users to read and write them as byte arrays, and currently expose this viaTryFrom<Vec<u8>>. This is fine, but there's no reason to not implementReadableas well, and it saves having to implementTryFromin bindings.