Skip to content

lightning-invoice: Add Description::as_inner #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

MaxFangX
Copy link
Contributor

v0.0.119 introduced a lightning_invoice::Description newtype which doesn't allow accessing the inner UntrustedString without cloning the entire Description. Adds a quick fn Description::as_inner -> &UntrustedString which users can use to get the underlying &str if needed.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (951174a) to head (2a8ab6f).

Files Patch % Lines
lightning-invoice/src/lib.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
- Coverage   89.77%   89.71%   -0.06%     
==========================================
  Files         122      122              
  Lines      101495   101498       +3     
  Branches   101495   101498       +3     
==========================================
- Hits        91114    91064      -50     
- Misses       7693     7737      +44     
- Partials     2688     2697       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull tnull merged commit a76ec06 into lightningdevkit:main Jul 24, 2024
16 of 19 checks passed
@MaxFangX MaxFangX deleted the pr/description-as-inner branch July 24, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants