Add support for parsing the dns_resolver feature bit #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature bit is used to indicate that a node will make DNS queries on behalf of onion message senders, returning DNSSEC TXT proofs for the requested names. It is used to signal support for bLIP 32 resolution and can be used to find nodes from which we can try to resolve BIP 32 HRNs.
A `DNSResolverMessageHandler` which handles resolution requests should want the `NodeFeatures` included in the node's `node_announcement` to include `dns_resolver` to indicate to the world that it provides that service. Here we enable this by requesting extra feature flags from the `DNSResolverMessageHandler` in the features `OnionMessenger`, in turn, provides to `PeerManager` (which builds the `node_announcement`).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3346 +/- ##
==========================================
- Coverage 89.59% 89.56% -0.03%
==========================================
Files 127 127
Lines 103438 103441 +3
Branches 103438 103441 +3
==========================================
- Hits 92672 92651 -21
- Misses 8049 8066 +17
- Partials 2717 2724 +7 ☔ View full report in Codecov by Sentry. |
| @@ -177,6 +179,10 @@ mod sealed { | |||
| ZeroConf | Keysend, | |||
| // Byte 7 | |||
| Trampoline, | |||
| // Byte 8 - 31 | |||
| ,,,,,,,,,,,,,,,,,,,,,,,, | |||
There was a problem hiding this comment.
what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
There was a problem hiding this comment.
These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
jkczyz
approved these changes
Oct 8, 2024
| @@ -177,6 +179,10 @@ mod sealed { | |||
| ZeroConf | Keysend, | |||
| // Byte 7 | |||
| Trampoline, | |||
| // Byte 8 - 31 | |||
| ,,,,,,,,,,,,,,,,,,,,,,,, | |||
There was a problem hiding this comment.
These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
dunxen
approved these changes
Oct 8, 2024
|
Matches what's in bLIPs repo. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature bit is used to indicate that a node will make DNS
queries on behalf of onion message senders, returning DNSSEC TXT
proofs for the requested names.
It is used to signal support for bLIP 32 resolution and can be used
to find nodes from which we can try to resolve BIP 32 HRNs.
#3283 will want to use this, so after both PRs are merged we'll need one more commit to set the feature flag, but #3283 is already getting kinda big so keeping this separate.