Drop broken debug assertion on peer buffer lengths #3399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b711ed changed it so that we can enqueue broadcast gossip messages to peers even though their buffer is full as long as its our `ChannelMessageHandler` doing it. This broke a debug assertion that the buffer isn't too large when appending the broadcast message which is simply dropped here. Found by the `full_stack_target` fuzzer.
tnull
approved these changes
Nov 7, 2024
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Makes sense.
Somehow orthogonal, I wonder if we could/should start checking-in failed test cases to have the fuzzer check for regressions?
Collaborator
Author
|
Yea, I should probably do that...I keep not getting around to it because every time I get it done there's some new bug in the fuzz debug assertions cause the fuzzer finds yet another part of the code that gets sad if the blockchain has an invalid set of transactions (in which case we should panic) but where it panics cause the fuzzer can do invalid chains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b711ed changed it so that we can enqueue broadcast gossip messages to peers even though their buffer is full as long as its our
ChannelMessageHandlerdoing it. This broke a debug assertion that the buffer isn't too large when appending the broadcast message which is simply dropped here.Found by the
full_stack_targetfuzzer.