-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OffersMessageFlow #3412
base: main
Are you sure you want to change the base?
Commits on Nov 18, 2024
-
Introduce
message_received
in Offer/OnionMessageHandlerTo decouple offers and onion message-related code from `ChannelManager`, this commit introduces the `message_received` function in `Offer/OnionMessageHandler`. Currently, the function focuses on handling the retry logic for `InvoiceRequest` messages. Moving this responsibility ensures a cleaner separation of concerns and sets the foundation for managing offers/onion messages directly within the appropriate handler.
Configuration menu - View commit details
-
Copy full SHA for 9e47005 - Browse repository at this point
Copy the full SHA 9e47005View commit details -
Move
message_received
out ofChannelMessageHandler
Since `ChannelMessageHandler`'s `message_received` function was solely used for handling invoice request retries. This function has been removed from `ChannelMessageHandler`, and the relevant code has been migrated to `OffersMessageHandler`'s `message_received`. This ensures invoice request retries are now handled in the appropriate context.
Configuration menu - View commit details
-
Copy full SHA for d36e297 - Browse repository at this point
Copy the full SHA d36e297View commit details -
This commit introduces a new struct, `OffersMessageFlow`, to extract all offers message-related code out of `ChannelManager`. By moving this logic into a dedicated struct, it creates a foundation for separating responsibilities and sets up a base for further code restructuring in subsequent commits.
Configuration menu - View commit details
-
Copy full SHA for 9825101 - Browse repository at this point
Copy the full SHA 9825101View commit details
Commits on Nov 19, 2024
-
Introduce
OffersMessageCommons
Trait and ImplementationA new trait, `OffersMessageCommons`, is introduced to encapsulate functions that are commonly used by both BOLT12-related functionality and other parts of `ChannelManager`. This enables a clean transition of BOLT12 code to `OffersMessageFlow` by moving shared functions into the new trait, ensuring they remain accessible to both `ChannelManager` and the refactored BOLT12 code.
Configuration menu - View commit details
-
Copy full SHA for 9bd8f9c - Browse repository at this point
Copy the full SHA 9bd8f9cView commit details -
Refactor
OffersMessageHandler
Implementation toOffersMessageFlow
This commit introduces the `OffersMessageHandler` implementation for `OffersMessageFlow`, enabling direct access to offer-specific functionality through `OffersMessageFlow`. In subsequent commits, all other implementations of `OffersMessageHandler` will be removed, consolidating `OffersMessageHandler` as the single source of its implementation.
Configuration menu - View commit details
-
Copy full SHA for 57e8ccc - Browse repository at this point
Copy the full SHA 57e8cccView commit details -
This commit introduces `OffersMessageFlow` in `functional_test`, transitioning the source of `OffersMessageHandler` implementation to `OffersMessageFlow`. With this change, the `ChannelManager`'s implementation becomes redundant and will be removed in the next commit.
Configuration menu - View commit details
-
Copy full SHA for ac95bc0 - Browse repository at this point
Copy the full SHA ac95bc0View commit details -
Remove
OffersMessageHandler
Implementation forChannelManager
With `OffersMessageFlow` now serving as the source of `OffersMessageHandler` implementation, the implementation in `ChannelManager` is no longer needed and has been safely removed.
Configuration menu - View commit details
-
Copy full SHA for fde5b13 - Browse repository at this point
Copy the full SHA fde5b13View commit details -
- This commit introduces a new struct, `AnOffersMessageFlow`, which generically implements `OffersMessageFlow`. - In subsequent commits, this struct will be utilized for documentation purposes.
Configuration menu - View commit details
-
Copy full SHA for baee2d5 - Browse repository at this point
Copy the full SHA baee2d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9705a65 - Browse repository at this point
Copy the full SHA 9705a65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58b9fd2 - Browse repository at this point
Copy the full SHA 58b9fd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a59b356 - Browse repository at this point
Copy the full SHA a59b356View commit details -
Configuration menu - View commit details
-
Copy full SHA for e038951 - Browse repository at this point
Copy the full SHA e038951View commit details