Remove next_funding_txid tlv from Channel read/write
#3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optout21
reviewed
Nov 21, 2024
optout21
reviewed
Nov 21, 2024
optout21
requested changes
Nov 21, 2024
dunxen
force-pushed
the
2024-11-removenextfundingtxidpersist
branch
from
5f02ff5
to
b78ec80
Compare
Thanks. Done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3417 +/- ##
==========================================
- Coverage 89.22% 89.22% -0.01%
==========================================
Files 130 130
Lines 106965 106966 +1
Branches 106965 106966 +1
==========================================
- Hits 95438 95437 -1
+ Misses 8734 8731 -3
- Partials 2793 2798 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
optout21
approved these changes
Nov 21, 2024
jkczyz
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to remove this before release so that we can work on a way to not persist this but rather get it from other persisted data and just free up the TLV.
Note that the "added in 0.0.124" comment was incorrect as it was actually added in #3137 but the comment was stale. So it's safe to remove.
See #3137 (comment) for context.